[
https://issues.apache.org/jira/browse/HADOOP-13327?focusedWorklogId=513718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-513718
]
ASF GitHub Bot logged work on HADOOP-13327:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/20 19:12
Start Date: 18/Nov/20 19:12
Worklog Time Spent: 10m
Work Description: joshelser commented on pull request #2102:
URL: https://github.com/apache/hadoop/pull/2102#issuecomment-729894664
My only thought at this point is: are we creating a dichotomy by having
HFLUSH be deprecated in `StreamCapabilities` but not deprecated in `Syncable`?
The argument is that we would never have an implementor of hflush which
doesn't also implement hsync. However, every implementor of hsync should have
an implementation for hflush (even if that implementation is to just invoke
hsync).
Now that I've come to this, I think outputstream.md adequately does this. Do
you think it's appropriate to have a reciprocal javadoc reference from
`Syncable` back to `StreamCapabilities`? I was thinking, if I was writing
against this API, I might not know to go looking for StreamCapabilities if I
just start digging through the Syncable API. I would defer to your judgement
here (if you think it's unnecessary, I am not concerned).
This was a fantastic and thorough read. Thanks for taking the time to do it,
Steve!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 513718)
Time Spent: 4h 10m (was: 4h)
> Add OutputStream + Syncable to the Filesystem Specification
> -----------------------------------------------------------
>
> Key: HADOOP-13327
> URL: https://issues.apache.org/jira/browse/HADOOP-13327
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-13327-002.patch, HADOOP-13327-003.patch,
> HADOOP-13327-branch-2-001.patch
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Write down what a Filesystem output stream should do. While core the API is
> defined in Java, that doesn't say what's expected about visibility,
> durability, etc —and Hadoop Syncable interface is entirely ours to define.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
