dengzhhu653 commented on a change in pull request #2469: URL: https://github.com/apache/hadoop/pull/2469#discussion_r527029424
########## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLocatedFileStatusFetcher.java ########## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.mapred; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.FileUtil; +import org.apache.hadoop.fs.LocalFileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.PathFilter; +import org.apache.hadoop.test.GenericTestUtils; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +import java.io.File; +import java.io.IOException; + +public class TestLocatedFileStatusFetcher { + + private Configuration conf; + private FileSystem fileSys; + private boolean mkdirs; + private File dir = GenericTestUtils.getTestDir("test-localfs"); + private static long TIME_FOR_SLEEP = 10000; + + @Before + public void setup() throws Exception { + conf = new Configuration(false); + conf.set("fs.file.impl", MockFileSystem.class.getName()); + fileSys = FileSystem.getLocal(conf); + } + + @After + public void after() throws IOException { + if (mkdirs) { + FileUtil.fullyDelete(dir); + } + } + + @Test + public void testExecutorsShutDown() throws Exception { + Path scanPath = new Path(dir.getAbsolutePath()); + mkdirs = fileSys.mkdirs(scanPath); + Path[] dirs = new Path[] {scanPath}; + final LocatedFileStatusFetcher fetcher = new LocatedFileStatusFetcher(conf, dirs, true, + new PathFilter() { + @Override + public boolean accept(Path path) { + return true; + } + }, true); + + Thread t = new Thread() { Review comment: The fetcher.getFileStatuses will block the current thread by `condition.await()`, which would be notified by his own tasks, the problem would not be seen. Do fetcher.getFileStatuses in a separate thread to make it easy to interrupt the `condition.await()`, this can be seen in Hive, where uses another different thread to list file status. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
