[
https://issues.apache.org/jira/browse/HADOOP-17325?focusedWorklogId=514975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514975
]
ASF GitHub Bot logged work on HADOOP-17325:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/20 06:06
Start Date: 21/Nov/20 06:06
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2480:
URL: https://github.com/apache/hadoop/pull/2480#discussion_r528079002
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/MockStorageInterface.java
##########
@@ -137,9 +139,19 @@ private static String convertUriToDecodedString(URI uri) {
private static URI convertKeyToEncodedUri(String key) {
try {
- return new URIBuilder().setPath(key).build();
+ URI unEncodedURI = new URI(key);
+ return new URIBuilder().setPath(unEncodedURI.getRawPath())
+ .setScheme(unEncodedURI.getScheme()).build();
Review comment:
Seems only one test is failing, We can first convert the `key` to `Path`
and then use `getPath` instead of `getRawPath` in `URIBuilder`. Something like
this worked for me -
```suggestion
Path p = new Path(key);
URI unEncodedURI = p.toUri();
return new URIBuilder().setPath(unEncodedURI.getPath())
.setScheme(unEncodedURI.getScheme()).build();
```
Give a try, if this works, if everything comes out to be safe post your
testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 514975)
Time Spent: 40m (was: 0.5h)
> WASB: Test failure in trunk
> ---------------------------
>
> Key: HADOOP-17325
> URL: https://issues.apache.org/jira/browse/HADOOP-17325
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure, test
> Affects Versions: 3.3.0
> Reporter: Sneha Vijayarajan
> Assignee: Esfandiar Manii
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> WASB tests are failing in Apache trunk resulting in Yetus run failures for
> PRs.
>
> ||Reason||Tests||
> |Failed junit tests|hadoop.fs.azure.TestNativeAzureFileSystemMocked|
> | |hadoop.fs.azure.TestNativeAzureFileSystemConcurrency|
> | |hadoop.fs.azure.TestWasbFsck|
> | |hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked|
> | |hadoop.fs.azure.TestNativeAzureFileSystemFileNameCheck|
> | |hadoop.fs.azure.TestNativeAzureFileSystemContractMocked|
> | |hadoop.fs.azure.TestOutOfBandAzureBlobOperations|
> | |hadoop.fs.azure.TestBlobMetadata|
> Many PRs are hit by this. Test report link from one of the PRs:
> [https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2368/5/testReport/]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
