bgaborg commented on a change in pull request #2473:
URL: https://github.com/apache/hadoop/pull/2473#discussion_r530276592
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3ATestBase.java
##########
@@ -60,6 +60,9 @@ public void setup() throws Exception {
// filesystems which add default configuration resources to do it before
// our tests start adding/removing options. See HADOOP-16626.
FileSystem.getLocal(new Configuration());
+ // instantiate an S3A FS here here to force deprecated key load through the
+ // static initializers. See: HADOOP-17385
+ new S3AFileSystem();
Review comment:
I think it would be cleaner if we could run the static initializers
instead of creating an object without storing the reference. I know that
there's a comment there stating that this is required because of a jira, but I
don't see the point why would we create an object just to trigger side effects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
