[ 
https://issues.apache.org/jira/browse/HADOOP-17385?focusedWorklogId=516672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-516672
 ]

ASF GitHub Bot logged work on HADOOP-17385:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Nov/20 13:07
            Start Date: 25/Nov/20 13:07
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on a change in pull request 
#2473:
URL: https://github.com/apache/hadoop/pull/2473#discussion_r530360751



##########
File path: 
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3ATestBase.java
##########
@@ -60,6 +60,9 @@ public void setup() throws Exception {
     // filesystems which add default configuration resources to do it before
     // our tests start adding/removing options. See HADOOP-16626.
     FileSystem.getLocal(new Configuration());
+    // instantiate an S3A FS here here to force deprecated key load through the
+    // static initializers. See: HADOOP-17385
+    new S3AFileSystem();

Review comment:
       I was about to say I don't know a way to trigger instantiation of static 
class initializers except by a new() call, but actually we can invoke any 
static method. How about I add a new static `initializeClass()` call and load 
it.
   
   FWIW, what I'd really like is to be able to disable forced reload of 
configs, but I can't see a way to do that which wouldn't run the risk of damage




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 516672)
    Time Spent: 2h 10m  (was: 2h)

> ITestS3ADeleteCost.testDirMarkersFileCreation failure
> -----------------------------------------------------
>
>                 Key: HADOOP-17385
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17385
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Test runs after apply of recent patches HADOOP-17318 and HADOOP-17244 are 
> showing a failure in ITestS3ADeleteCost.testDirMarkersFileCreation
> Either one of the patches is failing and wasn't picked up, or the combined 
> changes are conflicting in some way. Not backporting HADOOP-17318 to 
> branch-3.3 until this is addressed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to