lzx404243 commented on a change in pull request #2482:
URL: https://github.com/apache/hadoop/pull/2482#discussion_r532282135
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/servlet/TestServerWebApp.java
##########
@@ -43,6 +43,8 @@ public void getHomeDir() {
assertEquals(ServerWebApp.getDir("TestServerWebApp0", ".log.dir",
"/tmp/log"), "/tmp/log");
System.setProperty("TestServerWebApp0.log.dir", "/tmplog");
assertEquals(ServerWebApp.getDir("TestServerWebApp0", ".log.dir",
"/tmp/log"), "/tmplog");
+ System.clearProperty("TestServerWebApp0.home.dir");
+ System.clearProperty("TestServerWebApp0.log.dir");
Review comment:
Hi @aajisaka,
thanks for your review! You raised some good points.
Per further discussion with Xiaoqiao He in [jira
link](https://issues.apache.org/jira/browse/HDFS-15691?focusedCommentId=17237118&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17237118),
it looks like setting the system properties can be harmless as system
properties are not reused in different tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
