LeonGao91 commented on a change in pull request #2483:
URL: https://github.com/apache/hadoop/pull/2483#discussion_r533650857
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
##########
@@ -435,6 +444,22 @@ private long init(List<DatanodeStorageReport> reports) {
return Math.max(overLoadedBytes, underLoadedBytes);
}
+ private void sortOverUtilizedNodes() {
+ LOG.info("Sorting over-utilized nodes by capacity" +
+ " to bring down top used datanode capacity faster");
+
+ if (overUtilized instanceof List) {
+ List<Source> list = (List<Source>) overUtilized;
+ list.sort(
+ (Source source1, Source source2) ->
Review comment:
Good idea, we should use utilization for storage type instead of
datanode utilization. Will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]