aajisaka commented on a change in pull request #2523:
URL: https://github.com/apache/hadoop/pull/2523#discussion_r537275285
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists-gtest.txt.in
##########
@@ -16,6 +19,18 @@
# limitations under the License.
#
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-missing-field-initializers
-Wno-unused-const-variable")
-add_library(gmock_main_obj OBJECT gmock-gtest-all.cc gmock_main.cc)
-add_library(gmock_main $<TARGET_OBJECTS:gmock_main_obj>)
+cmake_minimum_required(VERSION 2.8.2)
Review comment:
```suggestion
cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
