insideo commented on a change in pull request #2552:
URL: https://github.com/apache/hadoop/pull/2552#discussion_r543514752
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
##########
@@ -2158,6 +2158,10 @@ public static boolean isAclEnabled(Configuration conf) {
"org.apache.hadoop.yarn.server.nodemanager.containermanager" +
".linux.runtime.runc.HdfsManifestToResourcesPlugin";
+ /** The runc container transformer plugin to use. If empty, no
+ * transformations will be applied. */
+ public static final String NM_RUNC_CONTAINER_TRANSFORMER_PLUGIN = "";
Review comment:
I'm pretty sure this is being used as the conf key, not the value, so an
empty string is wrong here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
