jojochuang commented on a change in pull request #2568:
URL: https://github.com/apache/hadoop/pull/2568#discussion_r546804830
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
##########
@@ -1567,4 +1568,16 @@ public void
testAppSubmissionContextIsPrunedInFinalApplicationState()
Collections.emptyMap(), ctx.getApplicationSchedulingPropertiesMap());
store.close();
}
+
+ @Test
Review comment:
Not familiar with YARN code. The production code looks fine to me. The
test code should add more coverage for each of the methods in
ZKRMStateStoreOpDurations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
