[ 
https://issues.apache.org/jira/browse/HADOOP-17271?focusedWorklogId=528248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-528248
 ]

ASF GitHub Bot logged work on HADOOP-17271:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Dec/20 20:47
            Start Date: 24/Dec/20 20:47
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #2553:
URL: https://github.com/apache/hadoop/pull/2553#issuecomment-751015541


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 39s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  3s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  markdownlint  |   0m  1s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |   |   0m  0s | [test4tests](test4tests) |  The patch 
appears to include 56 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  13m 44s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 42s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  21m 13s |  |  trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  compile  |  18m  3s |  |  trunk passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 54s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 12s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  22m 19s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  3s |  |  trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  javadoc  |   2m 51s |  |  trunk passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +0 :ok: |  spotbugs  |   1m 16s |  |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   4m 59s |  |  trunk passed  |
   | -0 :warning: |  patch  |   1m 37s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  21m  0s |  |  the patch passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  javac  |  21m  0s |  |  
root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 2032 unchanged - 1 
fixed = 2032 total (was 2033)  |
   | +1 :green_heart: |  compile  |  17m 26s |  |  the patch passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +1 :green_heart: |  javac  |  17m 26s |  |  
root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 0 new + 1927 unchanged - 
1 fixed = 1927 total (was 1928)  |
   | -0 :warning: |  checkstyle  |   2m 47s | 
[/diff-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2553/4/artifact/out/diff-checkstyle-root.txt)
 |  root: The patch generated 19 new + 271 unchanged - 26 fixed = 290 total 
(was 297)  |
   | +1 :green_heart: |  mvnsite  |   3m 20s |  |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  |  The patch has no 
whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  3s |  |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  shadedclient  |  15m 28s |  |  patch has no errors 
when building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   1m  2s | 
[/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2553/4/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt)
 |  hadoop-common in the patch failed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.  |
   | -1 :x: |  javadoc  |   0m 43s | 
[/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2553/4/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt)
 |  
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 
with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 1 new + 
88 unchanged - 0 fixed = 89 total (was 88)  |
   | -1 :x: |  findbugs  |   1m 26s | 
[/new-findbugs-hadoop-tools_hadoop-aws.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2553/4/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html)
 |  hadoop-tools/hadoop-aws generated 8 new + 0 unchanged - 0 fixed = 8 total 
(was 0)  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   9m 46s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   7m  7s |  |  hadoop-mapreduce-client-core in 
the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 37s |  |  hadoop-aws in the patch passed. 
 |
   | +1 :green_heart: |  asflicense  |   0m 57s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 206m 47s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-tools/hadoop-aws |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.getChangeTrackerStatistics()
  At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.getChangeTrackerStatistics()
  At S3AInstrumentation.java:[line 1056] |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.getInputPolicy()
  At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.getInputPolicy()
  At S3AInstrumentation.java:[line 1265] |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.inputPolicySet(int)
  At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.inputPolicySet(int)
  At S3AInstrumentation.java:[line 1045] |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.merge(boolean)
  At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.merge(boolean)
  At S3AInstrumentation.java:[line 1111] |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.promoteInputStreamCountersToMetrics()
  At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.promoteInputStreamCountersToMetrics()
  At S3AInstrumentation.java:[line 1150] |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.toString()  
At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.toString()  
At S3AInstrumentation.java:[line 1072] |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$OutputStreamStatistics.blockUploadStarted(Duration,
 int)  At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$OutputStreamStatistics.blockUploadStarted(Duration,
 int)  At S3AInstrumentation.java:[line 1410] |
   |  |  Potentially ambiguous invocation of either an outer or inherited 
method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$OutputStreamStatistics.toString()  
At S3AInstrumentation.java:an outer or inherited method 
org.apache.hadoop.fs.s3a.statistics.impl.AbstractS3AStatisticsSource.getIOStatistics()
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$OutputStreamStatistics.toString()  
At S3AInstrumentation.java:[line 1556] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2553/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2553 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle markdownlint xml |
   | uname | Linux 3ca05c9c5334 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 005b854f6ba |
   | Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2553/4/testReport/ |
   | Max. process+thread count | 1576 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core 
hadoop-tools/hadoop-aws U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2553/4/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 528248)
    Time Spent: 9h 50m  (was: 9h 40m)

> S3A statistics to support IOStatistics
> --------------------------------------
>
>                 Key: HADOOP-17271
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17271
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 9h 50m
>  Remaining Estimate: 0h
>
> S3A to rework statistics with
> * API + Implementation split of the interfaces used by subcomponents when 
> reporting stats
> * S3A Instrumentation to implement all the interfaces
> * streams, etc to all implement IOStatisticsSources and serve to callers
> * Add some tracking of durations of remote requests



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to