[ 
https://issues.apache.org/jira/browse/HADOOP-17292?focusedWorklogId=529260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529260
 ]

ASF GitHub Bot logged work on HADOOP-17292:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Dec/20 20:54
            Start Date: 29/Dec/20 20:54
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #2576:
URL: https://github.com/apache/hadoop/pull/2576#issuecomment-752237975


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  24m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
6 new or modified test files.  |
   ||| _ branch-3.3 Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m  1s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 54s |  branch-3.3 passed  |
   | +1 :green_heart: |  compile  |  16m  4s |  branch-3.3 passed  |
   | +1 :green_heart: |  checkstyle  |   2m 44s |  branch-3.3 passed  |
   | +1 :green_heart: |  mvnsite  |   3m 16s |  branch-3.3 passed  |
   | +1 :green_heart: |  shadedclient  |  17m  3s |  branch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 34s |  branch-3.3 passed  |
   | +0 :ok: |  spotbugs  |   0m 57s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 39s |  branch/hadoop-project no findbugs 
output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 34s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 40s |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 40s |  the patch passed  |
   | +1 :green_heart: |  cc  |  15m 40s |  the patch passed  |
   | +1 :green_heart: |  golang  |  15m 40s |  the patch passed  |
   | -1 :x: |  javac  |  15m 40s |  root generated 1 new + 1872 unchanged - 0 
fixed = 1873 total (was 1872)  |
   | -0 :warning: |  checkstyle  |   2m 49s |  root: The patch generated 2 new 
+ 132 unchanged - 1 fixed = 134 total (was 133)  |
   | +1 :green_heart: |  mvnsite  |   3m 12s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 44s |  There were no new shelldocs 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  4s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  shadedclient  |  15m 51s |  patch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 41s |  the patch passed  |
   | +0 :ok: |  findbugs  |   0m 43s |  hadoop-project has no data from 
findbugs  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 42s |  hadoop-project in the patch 
passed.  |
   | -1 :x: |  unit  |  11m 58s |  hadoop-common in the patch passed.  |
   | +1 :green_heart: |  unit  |  10m  4s |  hadoop-mapreduce-client-nativetask 
in the patch passed.  |
   | -1 :x: |  asflicense  |   1m  6s |  The patch generated 2 ASF License 
warnings.  |
   |  |   | 181m 22s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.io.compress.TestCompressorDecompressor |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2576/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2576 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient xml cc findbugs checkstyle golang shellcheck 
shelldocs |
   | uname | Linux 73661674f7bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.3 / 3736f6e |
   | Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~16.04-b01 |
   | javac | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2576/1/artifact/out/diff-compile-javac-root.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2576/1/artifact/out/diff-checkstyle-root.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2576/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2576/1/testReport/ |
   | asflicense | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2576/1/artifact/out/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 1586 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-common-project/hadoop-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
 U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2576/1/console |
   | versions | git=2.7.4 maven=3.3.9 shellcheck=0.3.7 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 529260)
    Time Spent: 11h 40m  (was: 11.5h)

> Using lz4-java in Lz4Codec
> --------------------------
>
>                 Key: HADOOP-17292
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17292
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: common
>    Affects Versions: 3.3.0
>            Reporter: L. C. Hsieh
>            Assignee: L. C. Hsieh
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>          Time Spent: 11h 40m
>  Remaining Estimate: 0h
>
> In Hadoop, we use native libs for lz4 codec which has several disadvantages:
> It requires native libhadoop to be installed in system LD_LIBRARY_PATH, and 
> they have to be installed separately on each node of the clusters, container 
> images, or local test environments which adds huge complexities from 
> deployment point of view. In some environments, it requires compiling the 
> natives from sources which is non-trivial. Also, this approach is platform 
> dependent; the binary may not work in different platform, so it requires 
> recompilation.
> It requires extra configuration of java.library.path to load the natives, and 
> it results higher application deployment and maintenance cost for users.
> Projects such as Spark use [lz4-java|https://github.com/lz4/lz4-java] which 
> is JNI-based implementation. It contains native binaries in jar file, and it 
> can automatically load the native binaries into JVM from jar without any 
> setup. If a native implementation can not be found for a platform, it can 
> fallback to pure-java implementation of lz4.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to