goiri commented on a change in pull request #2578:
URL: https://github.com/apache/hadoop/pull/2578#discussion_r550277730
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java
##########
@@ -603,12 +604,15 @@ private int receivePacket() throws IOException {
mirrorAddr,
duration);
trackSendPacketToLastNodeInPipeline(duration);
- if (duration > datanodeSlowLogThresholdMs && LOG.isWarnEnabled()) {
- LOG.warn("Slow BlockReceiver write packet to mirror took " + duration
- + "ms (threshold=" + datanodeSlowLogThresholdMs + "ms), "
- + "downstream DNs=" + Arrays.toString(downstreamDNs)
- + ", blockId=" + replicaInfo.getBlockId()
- + ", seqno=" + seqno);
+ if (duration > datanodeSlowLogThresholdMs) {
+ datanode.metrics.incrPacketSlowWriteToMirror();
+ if (LOG.isWarnEnabled()) {
+ LOG.warn("Slow BlockReceiver write packet to mirror took " +
duration
+ + "ms (threshold=" + datanodeSlowLogThresholdMs + "ms), "
+ + "downstream DNs=" + Arrays.toString(downstreamDNs)
+ + ", blockId=" + replicaInfo.getBlockId()
Review comment:
As we are at it, let's use the logger format. We still need the Arrays
toString so we need the isWarnEnabled though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
