steveloughran commented on pull request #2464: URL: https://github.com/apache/hadoop/pull/2464#issuecomment-756759257
It's moot now that the PR is merged, but can I remind everyone ## Add a meaningful message to assertTrue/assertFalse asserts Imagine that you are trying to debug a test run from an automated build. All you have is that an assert failed on a given line. Does that provide enough information to diagnose the problem? Or would you need extra information? If so: what information should be included? It's OK to use assertJ's assertThat, which is where new tests are going. It's a bit more verbose but its assertions are very informative and easily extensible. If you haven't used the library yet -it's on the classpath, try using its assertions in new test suites. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
