[ 
https://issues.apache.org/jira/browse/HADOOP-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124426#comment-13124426
 ] 

Todd Lipcon commented on HADOOP-7729:
-------------------------------------

Hi Steve. I agree that we could do even more to help new users. But as some 
silly philosopher once said, "perfect is the enemy of the good". Another 
philosopher said something like "patches welcome" :) Mind if I commit as is and 
we can improve it further with another JIRA if you want?

In response to your particular points:
bq. Now, if you are really devious and the Server instance was told the port 
the HTTP server for that service was up on
This is problematic since some servers have lots of different HTTP endpoints, 
and also because the IPC portion of Hadoop is nicely divorced from the HTTP 
portion of Hadoop right now. Adding a dependence between them seems messy.

bq. Incidentally, what if the client is an HTTP1.0 browser? Shouldn't the HTTP 
version be grabbed from the incoming request? Or is that getting too close to 
building a mini-web-server?

I tested the patch with curl and google chrome. Both seemed to work fine. Given 
that HTTP 1.1 was introduced in 1999, I don't know if any HTTP 1.0 browsers are 
even out there anymore. Again, if someone has an incompatible browser, they're 
still no worse off with the patch than they were before.
                
> Send back valid HTTP response if user hits IPC port with HTTP GET
> -----------------------------------------------------------------
>
>                 Key: HADOOP-7729
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7729
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7729.txt
>
>
> Often, I've seen users get confused between the IPC ports and HTTP ports for 
> a daemon. It would be easy for us to detect when an HTTP GET request hits an 
> IPC port, and instead of sending back garbage, we can send back a valid HTTP 
> response explaining their mistake.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to