mehakmeet commented on a change in pull request #2604:
URL: https://github.com/apache/hadoop/pull/2604#discussion_r554590481



##########
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -144,6 +151,7 @@ public AbfsOutputStream(
     this.completionService = new 
ExecutorCompletionService<>(this.threadExecutor);
     this.cachedSasToken = new CachedSASToken(
         abfsOutputStreamContext.getSasTokenRenewPeriodForStreamsInSeconds());
+    ioStatistics = outputStreamStatistics.getIOStatistics();

Review comment:
       the way we currently create files in AzureblobFileSystemStore, we always 
give outputStreamStatistics in the context builder, but if we explicitly build 
an outputStream without outputStream stats, then we could have null pointer 
exceptions. If we are to have those checks then I'll have to branch a few 
methods using IOStatistics and outputStream stats to avoid this too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to