[ 
https://issues.apache.org/jira/browse/HADOOP-17272?focusedWorklogId=534014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534014
 ]

ASF GitHub Bot logged work on HADOOP-17272:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/21 16:28
            Start Date: 10/Jan/21 16:28
    Worklog Time Spent: 10m 
      Work Description: mehakmeet commented on a change in pull request #2604:
URL: https://github.com/apache/hadoop/pull/2604#discussion_r554590481



##########
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -144,6 +151,7 @@ public AbfsOutputStream(
     this.completionService = new 
ExecutorCompletionService<>(this.threadExecutor);
     this.cachedSasToken = new CachedSASToken(
         abfsOutputStreamContext.getSasTokenRenewPeriodForStreamsInSeconds());
+    ioStatistics = outputStreamStatistics.getIOStatistics();

Review comment:
       the way we currently create files in AzureblobFileSystemStore, we always 
give outputStreamStatistics in the context builder, but if we explicitly build 
an outputStream without outputStream stats, then we could have null pointer 
exceptions. If we are to have those checks then I'll have to branch a few 
methods using IOStatistics and outputStream stats to avoid this too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 534014)
    Time Spent: 4h 20m  (was: 4h 10m)

> ABFS Streams to  support IOStatistics API
> -----------------------------------------
>
>                 Key: HADOOP-17272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17272
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.3.1
>            Reporter: Steve Loughran
>            Assignee: Mehakmeet Singh
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> ABFS input/output streams to support IOStatistics API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to