mukund-thakur commented on a change in pull request #2594:
URL: https://github.com/apache/hadoop/pull/2594#discussion_r555093592
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInstrumentation.java
##########
@@ -1470,7 +1456,7 @@ public void blockUploadFailed(
@Override
public void bytesTransferred(long byteCount) {
bytesUploaded.addAndGet(byteCount);
- incrementGauge(STREAM_WRITE_BLOCK_UPLOADS_BYTES_PENDING, -byteCount);
+ incAllGauges(STREAM_WRITE_BLOCK_UPLOADS_BYTES_PENDING, -byteCount);
Review comment:
nit: why change in name as still only one guage is being incremented in
the method underneath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
