goiri commented on pull request #2605: URL: https://github.com/apache/hadoop/pull/2605#issuecomment-758187791
> @goiri Thanks for the further review. > I found these TestRouterWebHdfsContractXX are flaky with my change and I think they are related with the fact that for the MiniRouterDFSCluster these tests created (in RouterWebHDFSContract), datanodes are shared among nameservices. The datanode report would be sometimes overwritten as : ns0->/ns0/rack would be overwritten by ns1->/ns1/rack for the same dn. Therefore for some tests we saw that no available datanode was found. > Do you think we should fix it first? If so should it be in a separate patch? Thanks! Adding flaky tests is not a good idea. Let's try to fix it in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
