[
https://issues.apache.org/jira/browse/HADOOP-17465?focusedWorklogId=535588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-535588
]
ASF GitHub Bot logged work on HADOOP-17465:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/21 17:59
Start Date: 13/Jan/21 17:59
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #2613:
URL: https://github.com/apache/hadoop/pull/2613#discussion_r556720631
##########
File path: dev-support/docker/Dockerfile
##########
@@ -51,11 +51,14 @@ RUN apt-get -q update \
gcc \
git \
gnupg-agent \
+ hugo \
Review comment:
Good that we got rid of the explicit installation of boost, hugo and
protobuf.
##########
File path: dev-support/docker/Dockerfile
##########
@@ -91,38 +95,20 @@ ENV MAVEN_HOME /usr
# JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003)
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64
ENV FINDBUGS_HOME /usr
+ENV PROTOBUF_HOME /opt/protobuf
+ENV PATH "${PATH}:/opt/protobuf/bin"
-#######
-# Install Boost 1.72 (1.65 ships with Bionic)
-#######
-# hadolint ignore=DL3003
-RUN mkdir -p /opt/boost-library \
- && curl -L
https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download
> boost_1_72_0.tar.bz2 \
- && mv boost_1_72_0.tar.bz2 /opt/boost-library \
- && cd /opt/boost-library \
- && tar --bzip2 -xf boost_1_72_0.tar.bz2 \
- && cd /opt/boost-library/boost_1_72_0 \
- && ./bootstrap.sh --prefix=/usr/ \
- && ./b2 --without-python install \
- && cd /root \
- && rm -rf /opt/boost-library
-
-######
-# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)
-######
+####
+# Install pip (deprecated from Focal toolchain)
+####
# hadolint ignore=DL3003
-RUN mkdir -p /opt/protobuf-src \
- && curl -L -s -S \
-
https://github.com/protocolbuffers/protobuf/releases/download/v3.7.1/protobuf-java-3.7.1.tar.gz
\
- -o /opt/protobuf.tar.gz \
- && tar xzf /opt/protobuf.tar.gz --strip-components 1 -C /opt/protobuf-src \
- && cd /opt/protobuf-src \
- && ./configure --prefix=/opt/protobuf \
- && make install \
+RUN mkdir -p /opt/pip \
Review comment:
Why not use pip from the repo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 535588)
Time Spent: 3h 20m (was: 3h 10m)
> Update Dockerfile to use Focal
> ------------------------------
>
> Key: HADOOP-17465
> URL: https://issues.apache.org/jira/browse/HADOOP-17465
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 3.4.0
> Environment: Ubuntu
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Referring to the current Dockerfile, it seems like the toolchain provided by
> Ubuntu Bionic isn't on track with the versions of the libraries that are
> needed. Thus, we are separately installing Boost and other libraries (gcc-9
> and CMake 3.19 needed by HDFS-15740). All these won't be necessary if we
> upgrade to Focal as these library versions are part of the Focal toolchain
> itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
