[
https://issues.apache.org/jira/browse/HADOOP-16948?focusedWorklogId=537148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537148
]
ASF GitHub Bot logged work on HADOOP-16948:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/21 20:18
Start Date: 17/Jan/21 20:18
Worklog Time Spent: 10m
Work Description: billierinaldi commented on a change in pull request
#1925:
URL: https://github.com/apache/hadoop/pull/1925#discussion_r559232797
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -243,7 +255,24 @@ public String getPrimaryGroup() {
@Override
public void close() throws IOException {
- IOUtils.cleanupWithLogger(LOG, client);
+ List<ListenableFuture<?>> futures = new ArrayList<>();
+ for (SelfRenewingLease lease : leaseRefs.keySet()) {
+ if (lease == null) {
+ continue;
+ }
+ ListenableFuture<?> future = client.submit(() -> lease.free());
Review comment:
I am not sure. This is kind of a failsafe; I would not expect code to
close the filesystem without closing output streams first, so ideally this loop
will only be double checking that free() has already been called on these lease
instances without actually performing REST ops. If the output streams opened
for this FS instance (for designated single writer directories) have not been
closed before the filesystem is closed, this would perform a REST op for each
one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 537148)
Time Spent: 2h 20m (was: 2h 10m)
> ABFS: Support single writer dirs
> --------------------------------
>
> Key: HADOOP-16948
> URL: https://issues.apache.org/jira/browse/HADOOP-16948
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Priority: Minor
> Labels: abfsactive, pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This would allow some directories to be configured as single writer
> directories. The ABFS driver would obtain a lease when creating or opening a
> file for writing and would automatically renew the lease and release the
> lease when closing the file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
