xiaoyuyao commented on a change in pull request #2627:
URL: https://github.com/apache/hadoop/pull/2627#discussion_r560664364



##########
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/NetgroupCache.java
##########
@@ -55,21 +63,34 @@ public static void getNetgroups(final String user,
     }
   }
 
+  /**
+   * Get netgroups for a given user
+   *
+   * @param user get groups for this user
+   * @param groups put groups into this List

Review comment:
       NIT: "List" should be "Set"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to