belugabehr commented on a change in pull request #2633:
URL: https://github.com/apache/hadoop/pull/2633#discussion_r561252276
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
##########
@@ -3391,15 +3391,7 @@ private static void loadFileSystems() {
LOGGER.info("Full exception loading: {}", fs, e);
}
} catch (ServiceConfigurationError ee) {
- LOG.warn("Cannot load filesystem: " + ee);
- Throwable cause = ee.getCause();
- // print all the nested exception messages
- while (cause != null) {
- LOG.warn(cause.toString());
- cause = cause.getCause();
- }
- // and at debug: the full stack
- LOG.debug("Stack Trace", ee);
+ LOGGER.warn("Cannot load filesystem", ee);
Review comment:
I'm not sure what the capability of Commons Logger is, but in SLF4J, the
entire list of 'caused by' is printed so there is no need to do this manually
when switching loggers, but this may also just be an oversight, I'm not sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
