[
https://issues.apache.org/jira/browse/HADOOP-17482?focusedWorklogId=538679&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538679
]
ASF GitHub Bot logged work on HADOOP-17482:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/21 20:15
Start Date: 20/Jan/21 20:15
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #2633:
URL: https://github.com/apache/hadoop/pull/2633#discussion_r561251612
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
##########
@@ -260,8 +259,7 @@ public void run() {
} catch (InterruptedException ie) {
return;
} catch (Exception ie) {
- action.weakFs.get().LOG.warn("Failed to renew token, action=" + action,
- ie);
+ FileSystem.LOG.warn("Failed to renew token, action=" + action, ie);
Review comment:
Bad practice here. Accessing a static value in a non-static way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538679)
Time Spent: 0.5h (was: 20m)
> Remove Commons Logger from FileSystem Class
> -------------------------------------------
>
> Key: HADOOP-17482
> URL: https://issues.apache.org/jira/browse/HADOOP-17482
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Remove reference to Commons Logger in FileSystem, it already has SLF4J, so
> it's a bit weird to be mixing and matching and interweaving loggers in this
> way. Also, my hope is to eventually migrate everything to SLF4J to simplify
> things for downstream consumers of the common library.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
