[
https://issues.apache.org/jira/browse/HADOOP-17424?focusedWorklogId=539317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539317
]
ASF GitHub Bot logged work on HADOOP-17424:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/21 20:49
Start Date: 21/Jan/21 20:49
Worklog Time Spent: 10m
Work Description: smengcl edited a comment on pull request #2632:
URL: https://github.com/apache/hadoop/pull/2632#issuecomment-764895467
Not sure why `shadedclient` still
[complains](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/2/artifact/out/patch-shadedclient.txt)
that I calls into `jaegertracing` while I have clearly removed it.
```
[INFO] Running org.apache.hadoop.example.ITUseMiniCluster
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed:
2.605 s <<< FAILURE! - in org.apache.hadoop.example.ITUseMiniCluster
[ERROR] useWebHDFS(org.apache.hadoop.example.ITUseMiniCluster) Time
elapsed: 2.305 s <<< ERROR!
java.util.ServiceConfigurationError:
org.apache.hadoop.shaded.io.jaegertracing.spi.SenderFactory: Provider
org.apache.hadoop.shaded.io.jaegertracing.thrift.internal.senders.ThriftSenderFactory
not found
at java.util.ServiceLoader.fail(ServiceLoader.java:239)
at java.util.ServiceLoader.access$300(ServiceLoader.java:185)
at
java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:372)
at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
at
org.apache.hadoop.shaded.io.jaegertracing.internal.senders.SenderResolver.resolve(SenderResolver.java:60)
at
org.apache.hadoop.shaded.io.jaegertracing.Configuration$SenderConfiguration.getSender(Configuration.java:657)
at
org.apache.hadoop.shaded.io.jaegertracing.Configuration$ReporterConfiguration.getReporter(Configuration.java:547)
at
org.apache.hadoop.shaded.io.jaegertracing.Configuration$ReporterConfiguration.access$000(Configuration.java:507)
at
org.apache.hadoop.shaded.io.jaegertracing.Configuration.getTracerBuilder(Configuration.java:222)
at
org.apache.hadoop.tracing.TraceUtils.createAndRegisterTracer(TraceUtils.java:105)
at org.apache.hadoop.tracing.Tracer$Builder.build(Tracer.java:106)
```
Ran the shadedclient check locally (after recompiling) and got a successful
run. Will wait for the next yetus run.
```
mvn --batch-mode verify -fae --batch-mode -am -pl
hadoop-client-modules/hadoop-client-check-invariants -pl
hadoop-client-modules/hadoop-client-check-test-invariants -pl
hadoop-client-modules/hadoop-client-integration-tests -Dtest=NoUnitTests
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 539317)
Time Spent: 1.5h (was: 1h 20m)
> Replace HTrace with No-Op tracer
> --------------------------------
>
> Key: HADOOP-17424
> URL: https://issues.apache.org/jira/browse/HADOOP-17424
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Remove HTrace dependency as it is depending on old jackson jars. Use a no-op
> tracer for now to eliminate potential security issues.
> The plan is to move part of the code in
> [PR#1846|https://github.com/apache/hadoop/pull/1846] out here for faster
> review.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
