steveloughran commented on a change in pull request #2584:
URL: https://github.com/apache/hadoop/pull/2584#discussion_r562575365
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSBuilder.java
##########
@@ -61,6 +61,13 @@
*/
B opt(@Nonnull String key, float value);
+ /**
+ * Set optional long parameter for the Builder.
+ *
+ * @see #opt(String, String)
+ */
+ B opt(@Nonnull String key, long value);
+
Review comment:
I agree, but as well as it already being out there, I want to let
applications compile against any version of hadoop with the API, even if a
specific FS option isn't available, alongside allowing for custom FS opts. As
an example, I have a PoC of parquet lib which uses this which is designed to
compile against 3.3.x. (that isn't something I've stuck up as I use it to see
how this stuff could be added to a library...highlights what is broken right
now, specifically; S3A openFile.withFileStatus fails if used via Hive because
hive wraps the FileStatus to a different type from S3AFileStatus.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
