[
https://issues.apache.org/jira/browse/HADOOP-16202?focusedWorklogId=540138&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-540138
]
ASF GitHub Bot logged work on HADOOP-16202:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 11:41
Start Date: 22/Jan/21 11:41
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#2584:
URL: https://github.com/apache/hadoop/pull/2584#discussion_r562575365
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSBuilder.java
##########
@@ -61,6 +61,13 @@
*/
B opt(@Nonnull String key, float value);
+ /**
+ * Set optional long parameter for the Builder.
+ *
+ * @see #opt(String, String)
+ */
+ B opt(@Nonnull String key, long value);
+
Review comment:
I agree, but as well as it already being out there, I want to let
applications compile against any version of hadoop with the API, even if a
specific FS option isn't available, alongside allowing for custom FS opts. As
an example, I have a PoC of parquet lib which uses this which is designed to
compile against 3.3.x. (that isn't something I've stuck up as I use it to see
how this stuff could be added to a library...highlights what is broken right
now, specifically; S3A openFile.withFileStatus fails if used via Hive because
hive wraps the FileStatus to a different type from S3AFileStatus.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 540138)
Time Spent: 9h 10m (was: 9h)
> Stabilize openFile() and adopt internally
> -----------------------------------------
>
> Key: HADOOP-16202
> URL: https://issues.apache.org/jira/browse/HADOOP-16202
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs, fs/s3, tools/distcp
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> The {{openFile()}} builder API lets us add new options when reading a file
> Add an option {{"fs.s3a.open.option.length"}} which takes a long and allows
> the length of the file to be declared. If set, *no check for the existence of
> the file is issued when opening the file*
> Also: withFileStatus() to take any FileStatus implementation, rather than
> only S3AFileStatus -and not check that the path matches the path being
> opened. Needed to support viewFS-style wrapping and mounting.
> and Adopt where appropriate to stop clusters with S3A reads switched to
> random IO from killing download/localization
> * fs shell copyToLocal
> * distcp
> * IOUtils.copy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
