liuml07 commented on a change in pull request #2637:
URL: https://github.com/apache/hadoop/pull/2637#discussion_r562938386
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/MagicCommitIntegration.java
##########
@@ -49,19 +49,17 @@
private static final Logger LOG =
LoggerFactory.getLogger(MagicCommitIntegration.class);
private final S3AFileSystem owner;
- private final boolean magicCommitEnabled;
+ private final boolean magicCommitEnabled = true;
Review comment:
Is this required?
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/MagicCommitIntegration.java
##########
@@ -128,17 +126,15 @@ public PutTracker createTracker(Path path, String key) {
* @return a list of elements, possibly empty
*/
private List<String> finalDestination(List<String> elements) {
- return magicCommitEnabled ?
- MagicCommitPaths.finalDestination(elements)
- : elements;
+ return MagicCommitPaths.finalDestination(elements);
}
/**
* Is magic commit enabled?
* @return true if magic commit is turned on.
*/
public boolean isMagicCommitEnabled() {
- return magicCommitEnabled;
+ return true;
Review comment:
Deprecate this method as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
