[
https://issues.apache.org/jira/browse/HADOOP-17467?focusedWorklogId=541308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-541308
]
ASF GitHub Bot logged work on HADOOP-17467:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/21 21:32
Start Date: 25/Jan/21 21:32
Worklog Time Spent: 10m
Work Description: amahussein commented on a change in pull request #2640:
URL: https://github.com/apache/hadoop/pull/2640#discussion_r564057682
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/NetgroupCache.java
##########
@@ -55,6 +56,22 @@ public static void getNetgroups(final String user,
}
}
+ /**
Review comment:
Because I did not want to change the signature of the method as it could
be seen as not recommended to change the public static method.
I decided to make a new method so later I can mark `getNetgroups` as
`deprecated` and eventually remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 541308)
Time Spent: 3.5h (was: 3h 20m)
> netgroup-user is not added to Groups.cache
> ------------------------------------------
>
> Key: HADOOP-17467
> URL: https://issues.apache.org/jira/browse/HADOOP-17467
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 3.4.0
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> After the optimization in HADOOP-17079, both
> {{JniBasedUnixGroupsNetgroupMapping}} and
> {{ShellBasedUnixGroupsNetgroupMapping}} do not implement {{getGroupSet}}.
> As a result, {{Groups.load()}} load the cache calling {{fetchGroupSet}} which
> yield to the superclass {{JniBasedUnixGroupsMapping}} /
> {{ShellBasedUnixGroupsMapping}}.
> In other words, the groups mapping will never fetch from {{NetgroupCache}}.
> This alters the behavior of the implementation. Is there a reason to bypass
> loading. CC: [~xyao]
> This jira is to add missing implementation {{getGroupSet}} to
> {{JniBasedUnixGroupsNetgroupMapping}} and
> {{ShellBasedUnixGroupsNetgroupMapping}} .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
