steveloughran commented on a change in pull request #2530:
URL: https://github.com/apache/hadoop/pull/2530#discussion_r563800923
##########
File path:
hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
##########
@@ -1873,11 +1873,9 @@
<property>
<name>fs.s3a.committer.magic.enabled</name>
- <value>false</value>
+ <value>true</value>
Review comment:
gabor, disabling option is now in HADOOP-17483; #2637 a PR to completely
remove the switch entirely. Now we have to decide: do we want that, or would we
ever want to turn the s3a client into a dumb client which doesn't do "magic"
when start writing under certain paths?
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -1800,31 +1809,16 @@ public ObjectMetadata getObjectMetadata(Path path)
throws IOException {
* @return metadata
* @throws IOException IO and object access problems.
*/
- @VisibleForTesting
@Retries.RetryTranslated
- public ObjectMetadata getObjectMetadata(Path path,
+ private ObjectMetadata getObjectMetadata(Path path,
ChangeTracker changeTracker, Invoker changeInvoker, String operation)
throws IOException {
- checkNotClosed();
Review comment:
I think I had a good reason for doing this (it was a private method,
checks further up, etc). But looking at it now I'm concluding that whatever
that reason was -it's not enough. Restoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
