amahussein commented on a change in pull request #2640:
URL: https://github.com/apache/hadoop/pull/2640#discussion_r564057682
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/NetgroupCache.java
##########
@@ -55,6 +56,22 @@ public static void getNetgroups(final String user,
}
}
+ /**
Review comment:
Because I did not want to change the signature of the method as it could
be seen as not recommended to change the public static method.
I decided to make a new method so later I can mark `getNetgroups` as
`deprecated` and eventually remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
