[ 
https://issues.apache.org/jira/browse/HADOOP-17493?focusedWorklogId=542203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542203
 ]

ASF GitHub Bot logged work on HADOOP-17493:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jan/21 14:30
            Start Date: 26/Jan/21 14:30
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on pull request #2649:
URL: https://github.com/apache/hadoop/pull/2649#issuecomment-767578454


   tested s3 london with ` -Dparallel-tests -DtestsThreadCount=6 -Dmarkers=keep`
   
   one failure
   ```
   [INFO] Running org.apache.hadoop.fs.s3a.fileContext.ITestS3AFileContextURI
   [ERROR] Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
86.43 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.commit.ITestCommitOperations
   [ERROR] 
testBulkCommitFiles(org.apache.hadoop.fs.s3a.commit.ITestCommitOperations)  
Time elapsed: 5.369 s  <<< FAILURE!
   java.lang.AssertionError: Number of records written after third commit; 
first commit had 4: s3guard_metadatastore_record_writes expected:<1> but was:<2>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at 
org.apache.hadoop.fs.s3a.S3ATestUtils$MetricDiff.assertDiffEquals(S3ATestUtils.java:1022)
        at 
org.apache.hadoop.fs.s3a.commit.ITestCommitOperations.testBulkCommitFiles(ITestCommitOperations.java:664)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.lang.Thread.run(Thread.java:748)
   ```
   
   Notable I hadn't explicitly turned on S3Guard. The assertion says that a 
parent dir entry was written when it wasn't expected. I think this one of those 
tests which is a bit brittle to overloaded test runs, so that when the time a 
file write completes on the client is 1+ second after the POST finished on AWS, 
the time in S3Guard is out -the next list updates.
   
   Did not surface standalone
   ```
   [INFO] Running org.apache.hadoop.fs.s3a.commit.ITestCommitOperations
   [INFO] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
96.034 s - in org.apache.hadoop.fs.s3a.commit.ITestCommitOperations
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 542203)
    Time Spent: 50m  (was: 40m)

> renaming S3A Statistic DELEGATION_TOKENS_ISSUED to DELEGATION_TOKEN_ISSUED 
> broke tests downstream
> -------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-17493
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17493
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> HADOOP-16830/HADOOP-17271 renamed DELEGATION_TOKENS_ISSUED to 
> DELEGATION_TOKENS_ISSUED while trying to unify naming. This breaks downstream 
> code.
> Fix: revert back the name change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to