sodonnel commented on a change in pull request #2657:
URL: https://github.com/apache/hadoop/pull/2657#discussion_r566026704
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
##########
@@ -503,6 +503,7 @@ void compute() throws IOException {
}
} catch (IOException e) {
Review comment:
Yes, we could just remove the try-catch block entirely and let the
exception propagate upwards. However I wonder if it would make sense to catch
it as we do now, but add some more information to the log for later debugging,
eg the block causing the problem and the block index:
```
LOG.warn("Failed to get the checksum for block index {} and block{} in block
group {}", idx, block, blockGroup, e);
throw(e);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
