[
https://issues.apache.org/jira/browse/HADOOP-17508?focusedWorklogId=544943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544943
]
ASF GitHub Bot logged work on HADOOP-17508:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/21 19:56
Start Date: 31/Jan/21 19:56
Worklog Time Spent: 10m
Work Description: smengcl commented on a change in pull request #2664:
URL: https://github.com/apache/hadoop/pull/2664#discussion_r567475256
##########
File path: BUILDING.txt
##########
@@ -76,21 +76,16 @@ Installing required packages for clean install of Ubuntu
14.04 LTS Desktop:
$ make -j$(nproc)
$ sudo make install
* Protocol Buffers 3.7.1 (required to build native code)
- $ mkdir -p /opt/protobuf-3.7-src \
- && curl -L -s -S \
-
https://github.com/protocolbuffers/protobuf/releases/download/v3.7.1/protobuf-java-3.7.1.tar.gz
\
- -o /opt/protobuf-3.7.1.tar.gz \
- && tar xzf /opt/protobuf-3.7.1.tar.gz --strip-components 1 -C
/opt/protobuf-3.7-src \
- && cd /opt/protobuf-3.7-src \
- && ./configure\
- && make install \
- && rm -rf /opt/protobuf-3.7-src
+ $ curl -L -s -S
https://github.com/protocolbuffers/protobuf/releases/download/v3.7.1/protobuf-java-3.7.1.tar.gz
-o protobuf-3.7.1.tar.gz
+ $ tar xzf protobuf-3.7.1.tar.gz --strip-components 1 -C protobuf-3.7-src &&
cd protobuf-3.7-src
+ $ ./configure
+ $ make -j$(nproc)
Review comment:
Nice. This should speed things up a bit. :)
##########
File path: BUILDING.txt
##########
@@ -76,21 +76,16 @@ Installing required packages for clean install of Ubuntu
14.04 LTS Desktop:
$ make -j$(nproc)
$ sudo make install
* Protocol Buffers 3.7.1 (required to build native code)
- $ mkdir -p /opt/protobuf-3.7-src \
- && curl -L -s -S \
-
https://github.com/protocolbuffers/protobuf/releases/download/v3.7.1/protobuf-java-3.7.1.tar.gz
\
- -o /opt/protobuf-3.7.1.tar.gz \
- && tar xzf /opt/protobuf-3.7.1.tar.gz --strip-components 1 -C
/opt/protobuf-3.7-src \
- && cd /opt/protobuf-3.7-src \
- && ./configure\
- && make install \
- && rm -rf /opt/protobuf-3.7-src
+ $ curl -L -s -S
https://github.com/protocolbuffers/protobuf/releases/download/v3.7.1/protobuf-java-3.7.1.tar.gz
-o protobuf-3.7.1.tar.gz
+ $ tar xzf protobuf-3.7.1.tar.gz --strip-components 1 -C protobuf-3.7-src &&
cd protobuf-3.7-src
Review comment:
Gotta `mkdir protobuf-3.7-src` before running `tar` with `-C`. Otherwise
`tar` would just complain and quit here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 544943)
Time Spent: 40m (was: 0.5h)
> Simplify dependency installation instructions
> ---------------------------------------------
>
> Key: HADOOP-17508
> URL: https://issues.apache.org/jira/browse/HADOOP-17508
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 3.3.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The instructions for installing Protocol buffers and Boost seem to just be
> copied from Dockerfile and isn't friendly to read.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
