[
https://issues.apache.org/jira/browse/HADOOP-17482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276554#comment-17276554
]
Steve Loughran commented on HADOOP-17482:
-----------------------------------------
ok, there's a story here. The interface was protected and we didn't know which
external subclasses, if any, were using it.
This is why the comment above the line you've just changed says
{code}
/**
* This log is widely used in the org.apache.hadoop.fs code and tests,
* so must be considered something to only be changed with care.
*/
{code}
I see you've discovered most of the issues there. There's one more: a risk of
external use. Can you add it to the release notes
> Remove Commons Logger from FileSystem Class
> -------------------------------------------
>
> Key: HADOOP-17482
> URL: https://issues.apache.org/jira/browse/HADOOP-17482
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Remove reference to Commons Logger in FileSystem, it already has SLF4J, so
> it's a bit weird to be mixing and matching and interweaving loggers in this
> way. Also, my hope is to eventually migrate everything to SLF4J to simplify
> things for downstream consumers of the common library.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
