[
https://issues.apache.org/jira/browse/HADOOP-17513?focusedWorklogId=547151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547151
]
ASF GitHub Bot logged work on HADOOP-17513:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 17:27
Start Date: 03/Feb/21 17:27
Worklog Time Spent: 10m
Work Description: amahussein opened a new pull request #2678:
URL: https://github.com/apache/hadoop/pull/2678
[HADOOP-17513](https://issues.apache.org/jira/browse/HADOOP-17513)
Although YARN-10352 introduces `guava iterator import` in
[TestCapacitySchedulerMultiNodes-L#28](https://github.com/apache/hadoop/commit/6fc26ad5392a2a61ace60b88ed931fed3859365d#diff-34d534eb66cd9af6d7c47a9f643d598b1ad4cef3453219457769e92fbd4a649dR28),
it was committed to trunk without checkstyle errors.
According to [IllegalImportCheck#setIllegalPkgs
](https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheck.java),
the packages regex should be the prefix of the package. The code automatically
append "`\.*`" to the regex.
This PR is to fix the regex to match all `^com\.google\.common\..*`
CC: @aajisaka Can you please take a look to the changes and commit it to
trunk?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 547151)
Remaining Estimate: 0h
Time Spent: 10m
> Checkstyle IllegalImport does not catch guava imports
> -----------------------------------------------------
>
> Key: HADOOP-17513
> URL: https://issues.apache.org/jira/browse/HADOOP-17513
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Although YARN-10352 introduces {{guava iterator import}}, it was committed to
> trunk without checkstyle errors.
> According to [IllegalImportCheck#setIllegalPkgs
> |https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheck.java],
> the packages regex should be the prefix of the package. The code
> automatically append {{\.*}} to the regex.
> CC: [~aajisaka]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
