Jing9 commented on a change in pull request #2625:
URL: https://github.com/apache/hadoop/pull/2625#discussion_r570000126
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -815,6 +815,25 @@ public IOException call() {
String.format("FAILED TO ADD: %s: %s%n",
volume, ioe.getMessage()));
LOG.error("Failed to add volume: {}", volume, ioe);
+ /**
+ * TODO: Some cases are not supported yet with
+ * same-disk-tiering on. For example, when replacing a
+ * storage directory on same mount, we have check if same
+ * storage type already exists on the mount. In this case
+ * we need to remove existing vol first then add.
+ * Also, we will need to adjust new capacity ratio when
+ * refreshVolume in the future.
+ */
+ if (ioe.getMessage()
Review comment:
It may be better to check if there is conflict with the
same-disk-tiering feature when we first load the refreshVolume configuration.
I.e., we can do some verification on changedVolumes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
