mukund-thakur commented on a change in pull request #2646:
URL: https://github.com/apache/hadoop/pull/2646#discussion_r570284036
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -605,7 +607,9 @@ public void createDirectory(final Path path, final
FsPermission permission, fina
}
}
- public AbfsInputStream openFileForRead(final Path path, final
FileSystem.Statistics statistics)
+ public AbfsInputStream openFileForRead(final Path path,
Review comment:
Can we method overloading like
> public AbfsInputStream openFileForRead(final Path path,
final FileSystem.Statistics
statistics)
throws AzureBlobFileSystemException {
return openFileForRead(path,Optional.empty(), statistics);
}
so as to avoid changing everywhere in the tests especially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
