[
https://issues.apache.org/jira/browse/HADOOP-17038?focusedWorklogId=547802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547802
]
ASF GitHub Bot logged work on HADOOP-17038:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/21 19:21
Start Date: 04/Feb/21 19:21
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#2646:
URL: https://github.com/apache/hadoop/pull/2646#discussion_r570483886
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsPread.java
##########
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.ExecutionException;
+
+import org.junit.Test;
+
+import org.apache.hadoop.fs.FSDataInputStream;
+import org.apache.hadoop.fs.FutureDataInputStreamBuilder;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.azurebfs.AbstractAbfsIntegrationTest;
+import org.apache.hadoop.fs.azurebfs.constants.ConfigurationKeys;
+import org.apache.hadoop.fs.contract.ContractTestUtils;
+
+public class ITestAbfsPread extends AbstractAbfsIntegrationTest {
+
+ public ITestAbfsPread() throws Exception {
+ }
+
+ @Test
+ public void testPread() throws IOException {
+ describe("Testing preads in AbfsInputStream");
+ Path dest = path("ITestAbfsPread");
+
+ int dataSize = 100;
+ byte[] data = ContractTestUtils.dataset(dataSize, 'a', 26);
+ ContractTestUtils.writeDataset(getFileSystem(), dest, data, data.length,
+ dataSize, true);
+ int bytesToRead = 10;
+ try (FSDataInputStream inputStream = getFileSystem().open(dest)) {
+ assertTrue(
+ "unexpected stream type "
+ + inputStream.getWrappedStream().getClass().getSimpleName(),
+ inputStream.getWrappedStream() instanceof AbfsInputStream);
+ byte[] readBuffer = new byte[bytesToRead];
+ int pos = 0;
+ assertEquals(
+ "AbfsInputStream#read did not read the correct number of bytes",
+ bytesToRead, inputStream.read(pos, readBuffer, 0, bytesToRead));
+ assertTrue("AbfsInputStream#read did not read the correct bytes",
+ Arrays.equals(Arrays.copyOfRange(data, pos, pos + bytesToRead),
Review comment:
I Think assertJ does even more...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 547802)
Time Spent: 4h 10m (was: 4h)
> Support disabling buffered reads in ABFS positional reads
> ---------------------------------------------------------
>
> Key: HADOOP-17038
> URL: https://issues.apache.org/jira/browse/HADOOP-17038
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Major
> Labels: HBase, abfsactive, pull-request-available
> Attachments: HBase Perf Test Report.xlsx, screenshot-1.png
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Right now it will do a seek to the position , read and then seek back to the
> old position. (As per the impl in the super class)
> In HBase kind of workloads we rely mostly on short preads. (like 64 KB size
> by default). So would be ideal to support a pure pos read API which will not
> even keep the data in a buffer but will only read the required data as what
> is asked for by the caller. (Not reading ahead more data as per the read size
> config)
> Allow an optional boolean config to be specified while opening file for read
> using which buffered pread can be disabled.
> FutureDataInputStreamBuilder openFile(Path path)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
