[
https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=548715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-548715
]
ASF GitHub Bot logged work on HADOOP-17511:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/21 15:45
Start Date: 05/Feb/21 15:45
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2675:
URL: https://github.com/apache/hadoop/pull/2675#issuecomment-774112977
HADOOP-15711. Auditing: scope/coverage
running all the tests with auditing set to fail if any call is made
unaudited highlights scope for improvement.
Production
* Critical: nested scopes
* Committers: scoping
* S3GuardTool spans around lower-level operations.
* Multipart listing to become a spanned entry point.
Test
* create spans before all tests doing low-level things
## Still a WiP, needs
* new tests for new code
* full coverage
* stability on http referrer format. Even if doesn't yet use opentelemetry,
I'd like compatible names/structure
+thinking of seeing how to push in telemetry prepareRequest() into AWS SDK
logic so all SDK calls have span checking/header addition, and production code
would actually be slightly leaner.
Needs me to understand the SDK a bit better, then for the audit manager to
use an appropriate plugin point in the
SDK to hand off to the active audit for preparation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 548715)
Time Spent: 4.5h (was: 4h 20m)
> Add an Audit plugin point for S3A auditing/context
> --------------------------------------------------
>
> Key: HADOOP-17511
> URL: https://issues.apache.org/jira/browse/HADOOP-17511
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.3.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Add a way for auditing tools to correlate S3 object calls with Hadoop FS API
> calls.
> Initially just to log/forward to an auditing service.
> Later: let us attach them as parameters in S3 requests, such as opentrace
> headeers or (my initial idea: http referrer header -where it will get into
> the log)
> Challenges
> * ensuring the audit span is created for every public entry point. That will
> have to include those used in s3guard tools, some defacto public APIs
> * and not re-entered for active spans. s3A code must not call back into the
> FS API points
> * Propagation across worker threads
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
