[
https://issues.apache.org/jira/browse/HADOOP-15230?focusedWorklogId=549342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-549342
]
ASF GitHub Bot logged work on HADOOP-15230:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/21 22:29
Start Date: 07/Feb/21 22:29
Worklog Time Spent: 10m
Work Description: howardyoo commented on pull request #340:
URL: https://github.com/apache/hadoop/pull/340#issuecomment-774779708
This PR is going nowhere, so I'm closing it, after waiting for more than 2
years now. I first thought this would get merged pretty easily, but somehow
this never worked. Maybe I have not done this correctly, but it's hard to know
by now. I've been getting email notifications about this sporadically, and was
getting annoyed more and more. Now, I guess I can finally say it was a nice
try, and good experience. Anyway, I am ready to let this go and forget about
it. Good bye!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 549342)
Time Spent: 0.5h (was: 20m)
> org.apache.hadoop.metrics2.GraphiteSink is not implemented correctly
> --------------------------------------------------------------------
>
> Key: HADOOP-15230
> URL: https://issues.apache.org/jira/browse/HADOOP-15230
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Reporter: Howard Yoo
> Assignee: Howard Yoo
> Priority: Major
> Labels: GraphiteSink,, metrics, pull-request-available
> Attachments: HADOOP-15230.007.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> org.apache.hadoop.metrics2.GraphiteSink's implementation has certain problems
> that would make it to generate metrics incorrectly.
> The problem lies with line 77 ~ 84 of the GraphiteSink java:
> {code:java}
> for (MetricsTag tag : record.tags()) {
> if (tag.value() != null) {
> metricsPathPrefix.append(".");
> metricsPathPrefix.append(tag.name());
> metricsPathPrefix.append("=");
> metricsPathPrefix.append(tag.value());
> }
> }
> {code}
> It produces point tags having name=value pair in the metrics. However, notice
> how the tags are added with '.' as its delimiters. Rather than using the '.'
> character, it should follow the following convention mentioned in the latest
> graphite doc of using ';' character.
> [http://graphite.readthedocs.io/en/latest/tags.html]
> Also, the value is not properly being escaped, meaning that if the value has
> a '.' character in it, it will easily confuse Graphite to accept it as a
> delimiter, rather than the value. A really good prime example is when the
> value is a hostname or ip address,
> {code:java}
> metrics.example.Hostname=this.is.a.hostname.and.this.is.Metrics 10.0{code}
> In this example, the since the value of the hostname contains '.', it is
> extremely hard for the receiving end to determine which part is hostname and
> which part is the rest of the metrics name. A good strategy is to convert any
> '.' character in the value to be converted to other characters, such as '_'.
> However, the best way would be to follow the latest metrics convention of
> using ';'
> {code:java}
> metrics.example.and.this.is.Metrics;Hostname=this.is.a.hostname 10.0{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
