[ 
https://issues.apache.org/jira/browse/HADOOP-16767?focusedWorklogId=549400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-549400
 ]

ASF GitHub Bot logged work on HADOOP-16767:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Feb/21 06:04
            Start Date: 08/Feb/21 06:04
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #2685:
URL: https://github.com/apache/hadoop/pull/2685#issuecomment-774893442


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  11m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ branch-2.10 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  16m 14s |  branch-2.10 passed  |
   | +1 :green_heart: |  compile  |   0m 33s |  branch-2.10 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 24s |  branch-2.10 passed  |
   | +1 :green_heart: |  mvnsite  |   0m 45s |  branch-2.10 passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  branch-2.10 passed  |
   | +0 :ok: |  spotbugs  |   1m  8s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   1m  4s |  branch-2.10 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 28s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 28s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   1m  7s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 39s |  hadoop-aws in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 31s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  38m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2685/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2685 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 59949fa7ed62 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-2.10 / ef14e16 |
   | Default Java | Oracle Corporation-1.7.0_95-b00 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2685/1/testReport/ |
   | Max. process+thread count | 195 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2685/1/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 549400)
    Time Spent: 0.5h  (was: 20m)

> S3AInputStream reopening does not handle non IO exceptions properly
> -------------------------------------------------------------------
>
>                 Key: HADOOP-16767
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16767
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.1.1
>            Reporter: Sergei Poganshev
>            Assignee: Sergei Poganshev
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.3.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Since only {{IOException}} is getting caught in 
> [closeStream|https://github.com/apache/hadoop/blob/24080666e5e2214d4a362c889cd9aa617be5de81/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L579],
>  {{reopen()}} fails in case {{SdkClientException}} occurs on a drain attempt. 
> This leads to multiple failing retries of {{invoker.retry("read",...)}} and 
> then the whole {{read()}} operation failing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to