steveloughran commented on pull request #2684: URL: https://github.com/apache/hadoop/pull/2684#issuecomment-775058042
Thanks @mukund-thakur Had some thoughts over the w/e 1. The call should return something, `AbortOutcome` which can include a list of non-critical exceptions caught during the call, just for diags. And to give us the option of adding IOStatistics to an impl 2. change the spec to differentiate "ops which MUST succeed for abort" (which for s3a is a no-op) and ops which MAY succeed and are which needed for cleanup. The MAY succeed operations SHOULD be best effort, but MUST NOT block for retries etc on failures. The s3a stream abort() does do retries right now, and I think that's probably a mistake for something which is only cleanup and is usually invoked when things are starting to go wrong (e.g. data post/complete). Saying "no retries here", means that we can have a fast abort() rather than a 60-120 second spin before the failure is caught and swallowed. I'll change the relevant bits of s3a abort to `once()` in this situation Makes sense? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
