[ 
https://issues.apache.org/jira/browse/HADOOP-13327?focusedWorklogId=549510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-549510
 ]

ASF GitHub Bot logged work on HADOOP-13327:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Feb/21 11:00
            Start Date: 08/Feb/21 11:00
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on a change in pull request 
#2587:
URL: https://github.com/apache/hadoop/pull/2587#discussion_r571955452



##########
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
##########
@@ -137,8 +139,13 @@ public void initialize(URI uri, Configuration conf) throws 
IOException {
             STREAM_READ_SKIP_BYTES)
         .build();
 
+    /** Reference to the bytes read counter for slightly faster counting. */
+    private final AtomicLong bytesRead;
+
     public LocalFSFileInputStream(Path f) throws IOException {
       fis = new FileInputStream(pathToFile(f));
+      bytesRead = ioStatistics.getCounterReference(

Review comment:
       this is a followon to IOStats...it was actually blocked on the buffer 
between row local fs output and FSDataOutput:
   `org.apache.hadoop.fs.statistics.BufferedIOStatisticsOutputStream` - needed 
for hsync passthrough to the File output stream. We're now generating IOStats 
for the local FS too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 549510)
    Time Spent: 9h 10m  (was: 9h)

> Add OutputStream + Syncable to the Filesystem Specification
> -----------------------------------------------------------
>
>                 Key: HADOOP-13327
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13327
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HADOOP-13327-002.patch, HADOOP-13327-003.patch, 
> HADOOP-13327-branch-2-001.patch
>
>          Time Spent: 9h 10m
>  Remaining Estimate: 0h
>
> Write down what a Filesystem output stream should do. While core the API is 
> defined in Java, that doesn't say what's expected about visibility, 
> durability, etc —and Hadoop Syncable interface is entirely ours to define.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to