[
https://issues.apache.org/jira/browse/HADOOP-17109?focusedWorklogId=552649&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-552649
]
ASF GitHub Bot logged work on HADOOP-17109:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/21 18:02
Start Date: 15/Feb/21 18:02
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2703:
URL: https://github.com/apache/hadoop/pull/2703#issuecomment-779378107
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 40s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 12s | | trunk passed |
| +1 :green_heart: | compile | 0m 20s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 21s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | mvnsite | 0m 20s | | trunk passed |
| +1 :green_heart: | shadedclient | 48m 33s | | branch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 24s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 15s | | the patch passed |
| +1 :green_heart: | compile | 0m 15s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 15s | | the patch passed |
| +1 :green_heart: | compile | 0m 14s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 0m 14s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 13s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no
whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | shadedclient | 12m 39s | | patch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 20s | | hadoop-build-tools in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not
generate ASF License warnings. |
| | | 68m 18s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2703/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2703 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux f455a51d93c9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / bad6038a487 |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2703/1/testReport/ |
| Max. process+thread count | 537 (vs. ulimit of 5500) |
| modules | C: hadoop-build-tools U: hadoop-build-tools |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2703/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 552649)
Time Spent: 40m (was: 0.5h)
> Replace Guava base64Url and base64 with Java8+ base64
> -----------------------------------------------------
>
> Key: HADOOP-17109
> URL: https://issues.apache.org/jira/browse/HADOOP-17109
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> One important thing to not here as pointed out by [~jeagles] in [his comment
> on the parent
> task|https://issues.apache.org/jira/browse/HADOOP-17098?focusedCommentId=17147935&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17147935]
> {quote}One note to be careful about is that base64 translation is not a
> standard, so the two implementations could produce different results. This
> might matter in the case of serialization, persistence, or client server
> different versions.{quote}
> *Base64Url:*
> {code:java}
> Targets
> Occurrences of 'base64Url' in project with mask '*.java'
> Found Occurrences (6 usages found)
> org.apache.hadoop.mapreduce (3 usages found)
> CryptoUtils.java (3 usages found)
> wrapIfNecessary(Configuration, FSDataOutputStream, boolean) (1
> usage found)
> 138 + Base64.encodeBase64URLSafeString(iv) + "]");
> wrapIfNecessary(Configuration, InputStream, long) (1 usage found)
> 183 + Base64.encodeBase64URLSafeString(iv) + "]");
> wrapIfNecessary(Configuration, FSDataInputStream) (1 usage found)
> 218 + Base64.encodeBase64URLSafeString(iv) + "]");
> org.apache.hadoop.util (2 usages found)
> KMSUtil.java (2 usages found)
> toJSON(KeyVersion) (1 usage found)
> 104 Base64.encodeBase64URLSafeString(
> toJSON(EncryptedKeyVersion) (1 usage found)
> 117
> .encodeBase64URLSafeString(encryptedKeyVersion.getEncryptedKeyIv()));
> org.apache.hadoop.yarn.server.resourcemanager.webapp (1 usage found)
> TestRMWebServicesAppsModification.java (1 usage found)
> testAppSubmit(String, String) (1 usage found)
> 837 .put("test",
> Base64.encodeBase64URLSafeString("value12".getBytes("UTF8")));
> {code}
> *Base64:*
> {code:java}
> Targets
> Occurrences of 'base64;' in project with mask '*.java'
> Found Occurrences (51 usages found)
> org.apache.hadoop.crypto.key.kms (1 usage found)
> KMSClientProvider.java (1 usage found)
> 20 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.crypto.key.kms.server (1 usage found)
> KMS.java (1 usage found)
> 22 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.fs (2 usages found)
> XAttrCodec.java (2 usages found)
> 23 import org.apache.commons.codec.binary.Base64;
> 56 BASE64;
> org.apache.hadoop.fs.azure (3 usages found)
> AzureBlobStorageTestAccount.java (1 usage found)
> 23 import com.microsoft.azure.storage.core.Base64;
> BlockBlobAppendStream.java (1 usage found)
> 50 import org.apache.commons.codec.binary.Base64;
> ITestBlobDataValidation.java (1 usage found)
> 50 import com.microsoft.azure.storage.core.Base64;
> org.apache.hadoop.fs.azurebfs (2 usages found)
> AzureBlobFileSystemStore.java (1 usage found)
> 99 import org.apache.hadoop.fs.azurebfs.utils.Base64;
> TestAbfsConfigurationFieldsValidation.java (1 usage found)
> 34 import org.apache.hadoop.fs.azurebfs.utils.Base64;
> org.apache.hadoop.fs.azurebfs.diagnostics (2 usages found)
> Base64StringConfigurationBasicValidator.java (1 usage found)
> 26 import org.apache.hadoop.fs.azurebfs.utils.Base64;
> TestConfigurationValidators.java (1 usage found)
> 25 import org.apache.hadoop.fs.azurebfs.utils.Base64;
> org.apache.hadoop.fs.azurebfs.extensions (2 usages found)
> MockDelegationSASTokenProvider.java (1 usage found)
> 37 import org.apache.hadoop.fs.azurebfs.utils.Base64;
> MockSASTokenProvider.java (1 usage found)
> 27 import org.apache.hadoop.fs.azurebfs.utils.Base64;
> org.apache.hadoop.fs.azurebfs.services (1 usage found)
> SharedKeyCredentials.java (1 usage found)
> 47 import org.apache.hadoop.fs.azurebfs.utils.Base64;
> org.apache.hadoop.fs.cosn (1 usage found)
> CosNativeFileSystemStore.java (1 usage found)
> 61 import com.qcloud.cos.utils.Base64;
> org.apache.hadoop.fs.s3a (1 usage found)
> EncryptionTestUtils.java (1 usage found)
> 26 import org.apache.commons.net.util.Base64;
> org.apache.hadoop.hdfs.protocol.datatransfer.sasl (3 usages found)
> DataTransferSaslUtil.java (1 usage found)
> 39 import org.apache.commons.codec.binary.Base64;
> SaslDataTransferClient.java (1 usage found)
> 47 import org.apache.commons.codec.binary.Base64;
> SaslDataTransferServer.java (1 usage found)
> 44 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.hdfs.server.common.blockaliasmap.impl (1 usage found)
> TextFileRegionAliasMap.java (1 usage found)
> 31 import java.util.Base64;
> org.apache.hadoop.hdfs.server.federation.store.driver.impl (1 usage
> found)
> StateStoreSerializerPBImpl.java (1 usage found)
> 22 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.hdfs.server.federation.store.protocol.impl.pb (1 usage
> found)
> FederationProtocolPBTranslator.java (1 usage found)
> 23 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.hdfs.server.namenode.web.resources (1 usage found)
> NamenodeWebHdfsMethods.java (1 usage found)
> 31 import java.util.Base64;
> org.apache.hadoop.hdfs.web (1 usage found)
> WebHdfsFileSystem.java (1 usage found)
> 43 import java.util.Base64;
> org.apache.hadoop.io (1 usage found)
> DefaultStringifier.java (1 usage found)
> 26 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.io.compress (1 usage found)
> TestCodec.java (1 usage found)
> 51 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.mapreduce (1 usage found)
> CryptoUtils.java (1 usage found)
> 24 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.mapreduce.security (1 usage found)
> SecureShuffleUtils.java (1 usage found)
> 29 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.registry.server.dns (2 usages found)
> RegistryDNS.java (1 usage found)
> 22 import org.apache.commons.net.util.Base64;
> TestRegistryDNS.java (1 usage found)
> 19 import org.apache.commons.net.util.Base64;
> org.apache.hadoop.security (1 usage found)
> SaslRpcServer.java (1 usage found)
> 42 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.security.authentication.client (2 usages found)
> KerberosAuthenticator.java (2 usages found)
> 18 import org.apache.commons.codec.binary.Base64;
> 152 private Base64 base64;
> org.apache.hadoop.security.authentication.server (5 usages found)
> KerberosAuthenticationHandler.java (1 usage found)
> 19 import org.apache.commons.codec.binary.Base64;
> LdapAuthenticationHandler.java (1 usage found)
> 34 import org.apache.commons.codec.binary.Base64;
> TestKerberosAuthenticationHandler.java (1 usage found)
> 20 import org.apache.commons.codec.binary.Base64;
> TestLdapAuthenticationHandler.java (1 usage found)
> 24 import org.apache.commons.codec.binary.Base64;
> TestMultiSchemeAuthenticationHandler.java (1 usage found)
> 33 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.security.authentication.util (2 usages found)
> Signer.java (1 usage found)
> 16 import org.apache.commons.codec.binary.Base64;
> TestKerberosUtil.java (1 usage found)
> 26 import java.util.Base64;
> org.apache.hadoop.security.token (1 usage found)
> Token.java (1 usage found)
> 24 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.util (1 usage found)
> KMSUtil.java (1 usage found)
> 20 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.yarn.applications.distributedshell (2 usages found)
> ApplicationMaster.java (1 usage found)
> 44 import java.util.Base64;
> Client.java (1 usage found)
> 34 import java.util.Base64;
> org.apache.hadoop.yarn.client.util (1 usage found)
> YarnClientUtils.java (1 usage found)
> 29 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher (1
> usage found)
> TestContainerLaunch.java (1 usage found)
> 59 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.yarn.server.resourcemanager.webapp (2 usages found)
> RMWebAppUtil.java (1 usage found)
> 30 import org.apache.commons.codec.binary.Base64;
> TestRMWebServicesAppsModification.java (1 usage found)
> 52 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.yarn.service.client (1 usage found)
> ApiServiceClient.java (1 usage found)
> 35 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.yarn.service.utils (1 usage found)
> HttpUtil.java (1 usage found)
> 30 import org.apache.commons.codec.binary.Base64;
> org.apache.hadoop.yarn.util (1 usage found)
> AuxiliaryServiceHelper.java (1 usage found)
> 24 import org.apache.commons.codec.binary.Base64;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
