[
https://issues.apache.org/jira/browse/HADOOP-17528?focusedWorklogId=553409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553409
]
ASF GitHub Bot logged work on HADOOP-17528:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/21 06:34
Start Date: 17/Feb/21 06:34
Worklog Time Spent: 10m
Work Description: mpryahin commented on a change in pull request #2701:
URL: https://github.com/apache/hadoop/pull/2701#discussion_r577357676
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/sftp/TestSFTPFileSystem.java
##########
@@ -374,4 +374,13 @@ public void testMkDirs() throws IOException {
assertThat(((SFTPFileSystem)
sftpFs).getConnectionPool().getLiveConnCount(),
is(1));
}
+
+ @Test
+ public void testCloseFileSystemClosesConnectionPool() throws Exception {
+ SFTPFileSystem fs = (SFTPFileSystem) sftpFs;
+ fs.getHomeDirectory();
+ assertThat(fs.getConnectionPool().getLiveConnCount(), is(1));
+ fs.close();
+ assertThat(fs.getConnectionPool().getLiveConnCount(), is(0));
+ }
Review comment:
Hey Steve, thanks a lot for reviewing, I appreciate it.
A FileSystem instance already gets closed after each test method, [please
take a look over
here](https://github.com/apache/hadoop/blob/ca2e5a462daeb48f2e18e6a0ebe2fd6a3f20e89e/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/sftp/TestSFTPFileSystem.java#L117).
I hope this makes the case you pointed out covered. Please, let me know if it
doesn't, I will add an extra call to make it look more explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 553409)
Time Spent: 40m (was: 0.5h)
> Not closing an SFTP File System instance prevents JVM from exiting.
> --------------------------------------------------------------------
>
> Key: HADOOP-17528
> URL: https://issues.apache.org/jira/browse/HADOOP-17528
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Mikhail Pryakhin
> Assignee: Mikhail Pryakhin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> SFTP file system leverages a connection pool which is not closed when a file
> system instance gets closed preventing a JVM from exiting as every SFTP
> connection runs in a separate non-daemon thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
