steveloughran commented on a change in pull request #2701:
URL: https://github.com/apache/hadoop/pull/2701#discussion_r577527796
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/sftp/TestSFTPFileSystem.java
##########
@@ -374,4 +374,13 @@ public void testMkDirs() throws IOException {
assertThat(((SFTPFileSystem)
sftpFs).getConnectionPool().getLiveConnCount(),
is(1));
}
+
+ @Test
+ public void testCloseFileSystemClosesConnectionPool() throws Exception {
+ SFTPFileSystem fs = (SFTPFileSystem) sftpFs;
+ fs.getHomeDirectory();
+ assertThat(fs.getConnectionPool().getLiveConnCount(), is(1));
+ fs.close();
+ assertThat(fs.getConnectionPool().getLiveConnCount(), is(0));
+ }
Review comment:
we swallow those exceptions in teardown as otherwise their exceptions
get reported over something in the test case itself (or setup). Please add the
extra call for completeness. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
