[
https://issues.apache.org/jira/browse/HADOOP-17538?focusedWorklogId=556276&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556276
]
ASF GitHub Bot logged work on HADOOP-17538:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/21 11:11
Start Date: 23/Feb/21 11:11
Worklog Time Spent: 10m
Work Description: iwasakims commented on a change in pull request #2716:
URL: https://github.com/apache/hadoop/pull/2716#discussion_r580950214
##########
File path: hadoop-project/src/site/site.xml
##########
@@ -216,6 +216,8 @@
<item name="hdfs-rbf-default.xml"
href="hadoop-project-dist/hadoop-hdfs-rbf/hdfs-rbf-default.xml"/>
<item name="mapred-default.xml"
href="hadoop-mapreduce-client/hadoop-mapreduce-client-core/mapred-default.xml"/>
<item name="yarn-default.xml"
href="hadoop-yarn/hadoop-yarn-common/yarn-default.xml"/>
+ <item name="kms-default.xml" href="hadoop-kms/kms-default.html"/>
+ <item name="httpfs-default.xml"
href="hadoop-hdfs-httpfs/httpfs-default.html"/>
Review comment:
> since some are going through hadoop-project-dist/
@ayushtkn The placement of docs seems to be decided based on parent pom of
the projects. hadoop-common and some hadoop-hdfs projects uses
hadoop-project-dist as its parents.
https://github.com/apache/hadoop/blob/rel/release-3.2.2/hadoop-common-project/hadoop-common/pom.xml#L20-L25
The parent of hadoop-kms and hadoop-hdfs-httpfs and many other projects is
hadoop-project.
https://github.com/apache/hadoop/blob/rel/release-3.2.2/hadoop-common-project/hadoop-kms/pom.xml#L22-L27
https://github.com/apache/hadoop/blob/rel/release-3.2.2/hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml#L22-L27
You can see the distribution by following cmdline on top of source tree.
```
$ find . -name pom.xml | xargs grep -A5 '<parent>' | less
```
This inconsistency might come from historical reason and could be addressed
in follow-up JIRAs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 556276)
Time Spent: 0.5h (was: 20m)
> Add kms-default.xml and httpfs-default.xml to site index
> --------------------------------------------------------
>
> Key: HADOOP-17538
> URL: https://issues.apache.org/jira/browse/HADOOP-17538
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> While there are links to *-default.xml in the site index, kms-default.xml and
> httpfs-default.xml are not included. Adding them could be useful as a quick
> reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
