amahussein commented on a change in pull request #2722:
URL: https://github.com/apache/hadoop/pull/2722#discussion_r582373743
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/ClusterMapReduceTestCase.java
##########
@@ -43,8 +45,21 @@
* The DFS filesystem is formated before the testcase starts and after it ends.
*/
public abstract class ClusterMapReduceTestCase {
+ private static final String TEST_ROOT_DEFAULT_PATH =
+ System.getProperty("test.build.data", "target/test-dir");
+ private static Path testRootDir;
+
private MiniDFSCluster dfsCluster = null;
- private MiniMRCluster mrCluster = null;
+ private MiniMRClientCluster mrCluster = null;
+
+ protected static void setupClassBase(Class<?> testClass) throws Exception {
+ // setup the test root directory
+ testRootDir = GenericTestUtils.setupTestRootDir(testClass,
+ TEST_ROOT_DEFAULT_PATH);
+ System.setProperty(GenericTestUtils.SYSPROP_TEST_DATA_DIR,
Review comment:
It will be set for the JVM executing the unittest. Each unit test should
then have its own property. Then they should not overlap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
