[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ANANDA G B updated HADOOP-17542:
--------------------------------
Description:
Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip. If
target is IPV6 ip then it throw "Does not contain a valid host:port authority:
".
This need be support.
public static InetSocketAddress createSocketAddr(String target,
int defaultPort,
String configName,
boolean useCacheIfPresent) {
String helpText = "";
if (configName != null)
{ helpText = " (configuration property '" + configName + "')"; }
if (target == null)
{ throw new IllegalArgumentException("Target address cannot be null." +
helpText); }
target = target.trim();
boolean hasScheme = target.contains("://");
URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
String host = uri.getHost();
int port = uri.getPort();
if (port == -1)
{ port = defaultPort; }
String path = uri.getPath();
if ((host == null) || (port < 0) ||
(!hasScheme && path != null && !path.isEmpty()))
{ throw new IllegalArgumentException( *"Does not contain a valid host:port
authority: " + target + helpText* ); }
return createSocketAddrForHost(host, port);
}
was:
Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip. If
target is IPV6 ip then it throw "Does not contain a valid host:port authority:
".
This need be support.
<code> public static InetSocketAddress createSocketAddr(String target,
int defaultPort,
String configName,
boolean useCacheIfPresent) {
String helpText = "";
if (configName != null)
{ helpText = " (configuration property '" + configName + "')"; }
if (target == null)
{ throw new IllegalArgumentException("Target address cannot be null." +
helpText); }
target = target.trim();
boolean hasScheme = target.contains("://");
URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
String host = uri.getHost();
int port = uri.getPort();
if (port == -1)
{ port = defaultPort; }
String path = uri.getPath();
if ((host == null) || (port < 0) ||
(!hasScheme && path != null && !path.isEmpty()))
{ throw new IllegalArgumentException( *"Does not contain a valid host:port
authority: " + target + helpText* ); }
return createSocketAddrForHost(host, port);
} <code>
> IPV6 support in Netutils#createSocketAddress
> ---------------------------------------------
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.1.1
> Reporter: ANANDA G B
> Priority: Minor
> Labels: ipv6
> Attachments: HADOOP-17542-HADOOP-11890-001.patch
>
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
